Comments on: P4A 3 goes RC

By: Fabrizio Balliano

Fabrizio Balliano — Sun, 11 May 2008 13:14:11 +0000

hum, a data source in a “not loaded” state is completely unuseful and broken thus you should avoid that state, I’m thinking about the unload but i’m a bit skeptical, I’ll talk to andrea about that :-)

By: Eddie

Eddie — Sat, 10 May 2008 06:52:28 +0000

Fabrizio,

i’m reading your code to understand the load() method, to avoid the reloading i use a flag, this flag should be in the class (_loaded), and two methods could be implemented: isLoaded() and unload(). What do you think..?

Saludos..!!

Eddie

By: Fabrizio Balliano

Fabrizio Balliano — Fri, 09 May 2008 06:51:31 +0000

@Eddie:
1 – i think we should not have methods that make users think that reloading a db_source is possible when it shuld not be done :-(

2 – if you don’t want to share the code you should buy a commercial license (it’s not available now, we’re working on that)

3 – try removing the “;” char from the query

By: Eddie

Eddie — Thu, 08 May 2008 17:15:13 +0000

Fabrizio,

Since the update to 3.0.0-rc my forms with select fields which the source is a query, resets the application.

Ex. (in form):

$field
->setSource(P4A::singleton()->lasts)
->setSourceDescriptionField(“code”);

Ex. (in main class):

$lasts =& $this->build(“P4A_DB_Source”, “lasts”);
$lasts
->setQuery(“SELECT * FROM periods;”)
->setPk(“id”)
->load();

—————————————

Eddie

By: Eddie

Eddie — Thu, 08 May 2008 16:16:32 +0000

Ok, i’ll try to implement my solution via helpers, anyway if you can add the methods resetJoin and resetMultivalueFields i’ll be satisfied.

In other words, i need to buy the license to use my application internally without share the source code. What is the procedure…?

Eddie

By: Fabrizio Balliano

Fabrizio Balliano — Thu, 08 May 2008 06:57:52 +0000

@Eddie: cause it recreated all data fields destroying the old ones, thus if you used them the references will be lost.

you should not change the structure of a db_source once it’s created, you should only change where/filters/orders but not its structure

By: Eddie

Eddie — Wed, 07 May 2008 22:08:39 +0000

Fabrizio,

Why re-call the load() method must be avoided..? Which is the best practice to solve my problem..?

Eddie

By: Fabrizio Balliano

Fabrizio Balliano — Tue, 06 May 2008 19:54:38 +0000

@Eddie: I’m wondering if add those methods to core but… I think that you’ve to launch the load() after modifying joins, but re-loading a db_source should be avoided

By: Fabrizio Balliano

Fabrizio Balliano — Tue, 06 May 2008 19:53:33 +0000

@Eddie: you could create 2 helpers instead of patching p4a’s files, check the p4a/helpers directory but it’s really easy :-)

By: Eddie

Eddie — Tue, 06 May 2008 19:48:20 +0000

Fabrizio, a process of my application re-configures the datasources and his relations, i use addJoin and addMultivalueField, but i had to implement two methods in P4_DB_Source: resetJoin and resetMultivalueField. These methods delete all or one indexed element. May be you can implement in the official version.

Saludos. Eddie.